From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754463AbbCQXRU (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 Mar 2015 19:17:20 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:52659 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752963AbbCQXRT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Mar 2015 19:17:19 -0400
Date: Tue, 17 Mar 2015 16:17:18 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Nicholas Mc Guire <hofrat@osadl.org>, Andy Whitcroft <apw@canonical.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: match more world writable permissions
Message-Id: <20150317161718.48428cd7a997cfa3ec4be90e@linux-foundation.org>
In-Reply-To: <1426290223.11459.62.camel@perches.com>
References: <1426274602-21196-1-git-send-email-hofrat@osadl.org>
	<1426290223.11459.62.camel@perches.com>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 13 Mar 2015 16:43:43 -0700 Joe Perches <joe@perches.com> wrote:

> Currently checkpatch will fuss if one uses world writable
> settings in debugfs files and DEVICE_ATTR uses by testing
> S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO.
> 
> Extend the check to catch all cases exporting world writable
> permissions including octal values.
> 
> @@ -443,6 +443,14 @@ foreach my $entry (@mode_permission_funcs) {
>  	$mode_perms_search .= $entry->[0];
>  }
>  
> +$our $mode_perms_world_writable = qr{
> +	S_IWUGO		|
> +	S_IWOTH		|
> +	S_IRWXUGO	|
> +	S_IALLUGO	|
> +	0[0-7][0-7][2367]
> +}x;
> +

Scalar found where operator expected at scripts/checkpatch.pl line 446, near "$our $mode_perms_world_writable"
        (Missing operator before $mode_perms_world_writable?)
Global symbol "$our" requires explicit package name at scripts/checkpatch.pl line 446.
syntax error at scripts/checkpatch.pl line 446, near "$our $mode_perms_world_writable "
Global symbol "$mode_perms_world_writable" requires explicit package name at scripts/checkpatch.pl line 446.
BEGIN not safe after errors--compilation aborted at scripts/checkpatch.pl line 663.

akpm3:/usr/src/25> perl --version

This is perl 5, version 18, subversion 2 (v5.18.2) built for x86_64-linux-gnu-thread-multi


This?

--- a/scripts/checkpatch.pl~checkpatch-match-more-world-writable-permissions-fix
+++ a/scripts/checkpatch.pl
@@ -443,7 +443,7 @@ foreach my $entry (@mode_permission_func
 	$mode_perms_search .= $entry->[0];
 }
 
-$our $mode_perms_world_writable = qr{
+our $mode_perms_world_writable = qr{
 	S_IWUGO		|
 	S_IWOTH		|
 	S_IRWXUGO	|
_