From: Peter Zijlstra <peterz@infradead.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: mingo@kernel.org, rusty@rustcorp.com.au,
mathieu.desnoyers@efficios.com, oleg@redhat.com,
linux-kernel@vger.kernel.org, andi@firstfloor.org,
rostedt@goodmis.org, tglx@linutronix.de
Subject: Re: [RFC][PATCH 2/9] module: Sanitize RCU usage and locking
Date: Tue, 17 Mar 2015 18:13:54 +0100 [thread overview]
Message-ID: <20150317171354.GG23123@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150302193706.GS15405@linux.vnet.ibm.com>
On Mon, Mar 02, 2015 at 11:37:06AM -0800, Paul E. McKenney wrote:
> > - /* Wait for RCU synchronizing before releasing mod->list and buglist. */
> > - synchronize_rcu();
> > + /* Wait for RCU-sched synchronizing before releasing mod->list and buglist. */
> > + synchronize_sched();
> > mutex_unlock(&module_mutex);
>
> There might be some reasons why the synchronize_sched() needs to be
> within the module_mutex critical section, but safe freeing of memory
> and the integrity of the list are not two of them. Doesn't hurt anything
> unless someone is being very active with their modules, of course.
Yeah, I could not find anything that relies on that; but I'm not too
familiar with all the module stuff -- although a lot more now that I was
a few weeks back ;-)
next prev parent reply other threads:[~2015-03-17 17:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 21:24 [RFC][PATCH 0/9] latched RB-trees and __module_address() Peter Zijlstra
2015-02-28 21:24 ` [RFC][PATCH 1/9] klp: Fix obvious RCU fail Peter Zijlstra
2015-03-01 20:09 ` Jiri Kosina
2015-03-02 8:35 ` Peter Zijlstra
2015-03-02 9:13 ` Jiri Kosina
2015-03-02 10:00 ` Peter Zijlstra
2015-03-02 9:21 ` Petr Mladek
2015-03-02 1:31 ` Masami Hiramatsu
2015-03-02 19:21 ` Paul E. McKenney
2015-03-02 21:07 ` Josh Poimboeuf
2015-02-28 21:24 ` [RFC][PATCH 2/9] module: Sanitize RCU usage and locking Peter Zijlstra
2015-03-02 11:16 ` Rusty Russell
2015-03-02 12:37 ` Peter Zijlstra
2015-03-02 19:37 ` Paul E. McKenney
2015-03-17 17:13 ` Peter Zijlstra [this message]
2015-02-28 21:24 ` [RFC][PATCH 3/9] module: Annotate module version magic Peter Zijlstra
2015-03-02 19:38 ` Paul E. McKenney
2015-02-28 21:24 ` [RFC][PATCH 4/9] module, jump_label: Fix module locking Peter Zijlstra
2015-03-02 19:39 ` Paul E. McKenney
2015-02-28 21:24 ` [RFC][PATCH 5/9] rbtree: Make lockless searches non-fatal Peter Zijlstra
2015-03-01 13:52 ` Mathieu Desnoyers
2015-03-02 8:27 ` Peter Zijlstra
2015-03-01 21:11 ` Michel Lespinasse
2015-03-02 7:46 ` Ingo Molnar
2015-03-02 8:23 ` Peter Zijlstra
2015-03-02 9:53 ` Peter Zijlstra
2015-02-28 21:24 ` [RFC][PATCH 6/9] seqlock: Better document raw_write_seqcount_latch() Peter Zijlstra
2015-03-01 14:02 ` Mathieu Desnoyers
2015-03-02 8:33 ` Peter Zijlstra
2015-03-02 8:51 ` Peter Zijlstra
2015-03-02 19:46 ` Paul E. McKenney
2015-03-01 21:12 ` Michel Lespinasse
2015-02-28 21:24 ` [RFC][PATCH 7/9] rbtree: Implement generic latch_tree Peter Zijlstra
2015-03-01 21:17 ` Michel Lespinasse
2015-03-02 8:05 ` Peter Zijlstra
2015-03-02 19:53 ` Paul E. McKenney
2015-03-17 17:24 ` Peter Zijlstra
2015-02-28 21:24 ` [RFC][PATCH 8/9] module: Optimize __module_address() using a latched RB-tree Peter Zijlstra
2015-02-28 21:24 ` [RFC][PATCH 9/9] module: Use __module_address() for module_address_lookup() Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317171354.GG23123@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome