From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754644AbbCQVlI (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 Mar 2015 17:41:08 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:51977 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752997AbbCQVlG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Mar 2015 17:41:06 -0400
Date: Tue, 17 Mar 2015 22:41:01 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Daniel Mack <daniel@zonque.org>
Cc: dh.herrmann@googlemail.com, tixxdz@opendz.org, dan.carpenter@oracle.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kdbus: connection: fix handling of failed fget()
Message-ID: <20150317214101.GB21729@kroah.com>
References: <1426618104-32401-1-git-send-email-daniel@zonque.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426618104-32401-1-git-send-email-daniel@zonque.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 17, 2015 at 07:48:24PM +0100, Daniel Mack wrote:
> The patch 5fc8dd5c84fc: "kdbus: add connection, queue handling and
> message validation code" from Sep 11, 2014, leads to the following
> static checker warning:
> 
> 	ipc/kdbus/connection.c:2000 kdbus_cmd_send()
> 	warn: 'cancel_fd' isn't an ERR_PTR
> 
> Fix this by checking for NULL pointers returned from fget().
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> ---
>  ipc/kdbus/connection.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Applied, thanks.

greg k-h