From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755342AbbCRH1H (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Mar 2015 03:27:07 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:56378 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754805AbbCRH1F (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Mar 2015 03:27:05 -0400
Date: Wed, 18 Mar 2015 08:27:02 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de,
        apw@canonical.com, vkuznets@redhat.com,
        Nick Meier <nmeier@microsoft.com>
Subject: Re: [PATCH 4/9] Correcting truncation error for constant
 HV_CRASH_CTL_CRASH_NOTIFY
Message-ID: <20150318072702.GB27585@kroah.com>
References: <1426639292-25415-1-git-send-email-kys@microsoft.com>
 <1426639321-25458-1-git-send-email-kys@microsoft.com>
 <1426639321-25458-4-git-send-email-kys@microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426639321-25458-4-git-send-email-kys@microsoft.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 17, 2015 at 05:41:56PM -0700, K. Y. Srinivasan wrote:
> From: Nick Meier <nmeier@microsoft.com>
> 
> HV_CRASH_CTL_CRASH_NOTIFY is a 64 bit number.  Depending on the usage context,
> the value may be truncated. This patch is in response from the following
> email from Intel:

"from Intel:" is really vague, please be nice and report who told you
about this problem.

> 
>     [char-misc:char-misc-testing 25/45] drivers/hv/vmbus_drv.c:67:9: sparse:
>                    constant 0x8000000000000000 is so big it is unsigned long
> 
>     tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
>     head:   b3de8e3719e582f3182bb504295e4a8e43c8c96f
>     commit: 96c1d0581d00f7abe033350edb021a9d947d8d81 [25/45] Drivers: hv: vmbus: Add support for VMBus panic notifier handler
>     reproduce:
>       # apt-get install sparse
>       git checkout 96c1d0581d00f7abe033350edb021a9d947d8d81
>       make ARCH=x86_64 allmodconfig
>       make C=1 CF=-D__CHECK_ENDIAN__
> 
>     sparse warnings: (new ones prefixed by >>)
> 
>     drivers/hv/vmbus_drv.c:67:9: sparse: constant 0x8000000000000000 is so big it is unsigned long
>     ...
> 
> The current char-next branch is broken and this patch fixes
> the bug.
> 
> Signed-off-by: Nick Meier <nmeier@microsoft.com>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>

You forgot a "Reported-by:" here.