From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755551AbbCRJH0 (ORCPT ); Wed, 18 Mar 2015 05:07:26 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:21337 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755461AbbCRJHT (ORCPT ); Wed, 18 Mar 2015 05:07:19 -0400 Date: Wed, 18 Mar 2015 10:09:06 +0100 From: Quentin Casasnovas To: Quentin Casasnovas , Rusty Russell , Michal Marek Cc: lkml , Oleg Nesterov , Borislav Petkov , Linus Torvalds Subject: Re: [PATCH 5/7] modpost: mismatch_handler: retrieve tosym information only when needed. Message-ID: <20150318090906.GJ19131@chrystal.uk.oracle.com> References: <1426596002-26128-1-git-send-email-quentin.casasnovas@oracle.com> <1426596002-26128-6-git-send-email-quentin.casasnovas@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426596002-26128-6-git-send-email-quentin.casasnovas@oracle.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding Rusty and Michal to CC. On Tue, Mar 17, 2015 at 01:40:00PM +0100, Quentin Casasnovas wrote: > Signed-off-by: Quentin Casasnovas > --- > scripts/mod/modpost.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index c69681e..bf0cf81 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -1432,16 +1432,17 @@ static void default_mismatch_handler(const char *modname, struct elf_info *elf, > const char *tosym; > const char *fromsym; > > - tosec = sec_name(elf, get_secindex(elf, sym)); > from = find_elf_symbol2(elf, r->r_offset, fromsec); > fromsym = sym_name(elf, from); > - to = find_elf_symbol(elf, r->r_addend, sym); > - tosym = sym_name(elf, to); > > if (!strncmp(fromsym, "reference___initcall", > sizeof("reference___initcall")-1)) > return; > > + tosec = sec_name(elf, get_secindex(elf, sym)); > + to = find_elf_symbol(elf, r->r_addend, sym); > + tosym = sym_name(elf, to); > + > /* check whitelist - we may ignore it */ > if (secref_whitelist(mismatch, > fromsec, fromsym, tosec, tosym)) { > -- > 2.0.5 >