From: Peter Zijlstra <peterz@infradead.org>
To: Vinson Lee <vlee@twopensource.com>
Cc: Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Namhyung Kim <namhyung@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org, Vinson Lee <vlee@twitter.com>,
Yann Droneaud <ydroneaud@opteya.com>
Subject: Re: [PATCH] perf tools: Work around lack of sched_getcpu in glibc < 2.6.
Date: Wed, 18 Mar 2015 10:15:27 +0100 [thread overview]
Message-ID: <20150318091527.GM23123@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CAHTgTXVQZDk4Eu8=aVU+fojFNNZ8Fm2aL0W5s0Rmd1aHNe76rQ@mail.gmail.com>
On Tue, Mar 17, 2015 at 04:49:13PM -0700, Vinson Lee wrote:
> On Mon, Feb 16, 2015 at 12:50 PM, Yann Droneaud <ydroneaud@opteya.com> wrote:
> >> +#ifdef __GLIBC_PREREQ
> >> +#if __GLIBC_PREREQ(2, 6)
> >> +#define HAVE_SCHED_GETCPU
> >> +#endif
> >> +#endif
> >> @@ -21,9 +27,13 @@ static int perf_flag_probe(void)
> >> pid_t pid = -1;
> >> char sbuf[STRERR_BUFSIZE];
> >>
> >> +#ifdef HAVE_SCHED_GETCPU
> >> cpu = sched_getcpu();
> >> if (cpu < 0)
> >> cpu = 0;
> >> +#else
> >> + cpu = 0;
> >> +#endif
> >>
> >> while (1) {
> >> /* check cloexec flag */
Would it not be much nicer to implement a sched_getcpu() stub that
returns -1 and sets errno to -ENOSYS or something?
That avoids the magic #ifdef mushroom.
next prev parent reply other threads:[~2015-03-18 9:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-14 2:06 Vinson Lee
2015-02-16 20:50 ` Yann Droneaud
2015-03-17 23:49 ` Vinson Lee
2015-03-18 9:15 ` Peter Zijlstra [this message]
2015-03-18 23:11 ` [PATCH v2] " Vinson Lee
2015-03-19 10:13 ` Jiri Olsa
2015-03-19 13:14 ` Arnaldo Carvalho de Melo
2015-03-19 21:12 ` Vinson Lee
2015-03-20 13:03 ` Arnaldo Carvalho de Melo
2015-03-20 18:44 ` Vinson Lee
2015-03-20 20:38 ` Arnaldo Carvalho de Melo
2015-03-23 19:09 ` [PATCH v3] " Vinson Lee
2015-03-24 0:21 ` Namhyung Kim
2015-03-24 7:10 ` Jiri Olsa
2015-03-24 16:32 ` [tip:perf/core] " tip-bot for Vinson Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318091527.GM23123@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=vlee@twitter.com \
--cc=vlee@twopensource.com \
--cc=ydroneaud@opteya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome