From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932523AbbCRJnt (ORCPT ); Wed, 18 Mar 2015 05:43:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32896 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755397AbbCRJns (ORCPT ); Wed, 18 Mar 2015 05:43:48 -0400 Date: Wed, 18 Mar 2015 10:43:44 +0100 From: Jiri Olsa To: Adrian Hunter Cc: "H.J. Lu" , Arnaldo Carvalho de Melo , "H. Peter Anvin" , Namhyung Kim , LKML , Jiri Olsa Subject: Re: [PATCH] Check ARCH and IS_64_BIT instead of IS_X86_64 in perf Message-ID: <20150318094344.GA30872@krava.brq.redhat.com> References: <5509362A.8030202@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5509362A.8030202@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 10:24:10AM +0200, Adrian Hunter wrote: > Hi > > +Arnaldo > +Jiri > > I would change the commit message and subject. Say: > > Subject: perf tools: Fix perf-read-vdsox32 not building and lib64 install dir > > Commit: > > c6e5e9fbc3ea ("perf tools: Fix building error in x86_64 when dwarf unwind is on") > > removed the definition of IS_X86_64 but not all places > using it, with the consequence that perf-read-vdsox32 > would not be built anymore, and the default lib install > directory was 'lib' instead of 'lib64'. > > Also needs to go to v3.19. > > Otherwise: > > Acked-by: Adrian Hunter > Cc: stable@vger.kernel.org # 3.19 Acked-by: Jiri Olsa thanks, jirka