From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756177AbbCRMD0 (ORCPT ); Wed, 18 Mar 2015 08:03:26 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:53168 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755992AbbCRMDX (ORCPT ); Wed, 18 Mar 2015 08:03:23 -0400 Date: Wed, 18 Mar 2015 12:03:10 +0000 From: Mark Brown To: leroy christophe Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-spi@vger.kernel.org Message-ID: <20150318120310.GH2869@sirena.org.uk> References: <20150226161142.D08681A2360@localhost.localdomain> <20150303184403.GE21293@sirena.org.uk> <54F6BBA7.8040008@c-s.fr> <20150306114413.GM21293@sirena.org.uk> <550137C5.1020109@c-s.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VkqCAaSJIySsbD6j" Content-Disposition: inline In-Reply-To: <550137C5.1020109@c-s.fr> X-Cookie: Wanna buy a duck? User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --VkqCAaSJIySsbD6j Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 12, 2015 at 07:52:53AM +0100, leroy christophe wrote: > Le 06/03/2015 12:44, Mark Brown a =E9crit : > >It's legacy, all that code is really old. Modern code is written in as > >architecture and firmware neutral a fashion as possible to make things > >more consistent and maintainable. > This patch is only a small bug fix. > That driver already contains calls to of_iomap() and other related of_ > functions. > Is it worth rewriting the driver for just a small bug fix ? I don't think you need to fix other usages but I'd rather not introduce new usages of legacy APIs that just need to be fixed up. --VkqCAaSJIySsbD6j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVCWl+AAoJECTWi3JdVIfQfZsH/0fCYhhOEQLFPasU8BgvaLBP xrfFRNI70rtnduJIRrUQZyYToXK3K63n2s3h3irKb7w80/id7d93fEv/NATIqQ/I /8I7HuuV59ojtpMEKQISVxXAokxwOZhERQWPCpHFRAYndLgUD/r20Oo/kY0quj/m 39ka5bhDK16jCbfUSpyCNmKJ2Xt0vqIeE9lhGepnkoDjCFd/JMvYXj0zPrPcAbsx SEk6rjwDwd3cX3Qq895Lt4bTfpExJRckqpstF2a9hRNG7EIKeisgSuNGZzSt49Y9 kqCLK6ai+Qvx2p/a78Q11eEnnih02VRVCZ5WnSZ361jUCMaozJrYI8Zk8q3VWWw= =dop1 -----END PGP SIGNATURE----- --VkqCAaSJIySsbD6j--