From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756414AbbCRMZw (ORCPT ); Wed, 18 Mar 2015 08:25:52 -0400 Received: from cassarossa.samfundet.no ([193.35.52.29]:42585 "EHLO cassarossa.samfundet.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756382AbbCRMZs (ORCPT ); Wed, 18 Mar 2015 08:25:48 -0400 Date: Wed, 18 Mar 2015 13:25:38 +0100 From: Hans-Christian Egtvedt To: Ben Dooks Cc: linux-kernel@lists.codethink.co.uk, Linux Networking List , Arun Chandran , Haavard Skinnemoen , Linux Kernel List , Nicolas Ferre Subject: Re: [PATCH] net: macb: fix endian code for avr32 Message-ID: <20150318122538.GA19497@samfundet.no> References: <1426676247-14023-1-git-send-email-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426676247-14023-1-git-send-email-ben.dooks@codethink.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Around Wed 18 Mar 2015 10:57:27 +0000 or thereabout, Ben Dooks wrote: > [note this has yet to be compile tested on avr32] > Compiles fine without warnings. > The changes to run the macb driver in 29af05aeb98e ("net: macb: > Add big endian CPU support") to support big endian operation on > ARM may not work on AVR32 which already is naturally big endian > architecture (and the driver already works here). The 29af05aeb98e will brick the macb driver for AVR32, as readZ_relaxed translates to readZ calls, which turns into le_to_cpu reads. > In this case the readl/writel relaxed will do the opposite of __raw > accesors which arleady work. Add an indirection of cdneth_ prefixed > accesors which are changed as necessary. Also do not issue the DMA > descritpor endian fetch configuration for AVR32. > > From discussions with Arnd Bergman, the following fix changes the use > of readl_relaxed and writel_relaxed with a version that can be put > back to __raw_readl/__raw_writel for the CONFIG_AVR32 case (and also > remove the change to the DMA descriptor endian). Thank you for spotting this. > Signed-off-by: Ben Dooks > Reported-by: Arnd Bergmann Acked-by: Hans-Christian Egtvedt > -- > CC: Linux Networking List > CC: Arun Chandran > CC: Haavard Skinnemoen > CC: Hans-Christian Egtvedt > CC: Linux Kernel List > CC: Nicolas Ferre > --- > drivers/net/ethernet/cadence/macb.c | 14 +++++++------- > drivers/net/ethernet/cadence/macb.h | 20 ++++++++++++++------ > 2 files changed, 21 insertions(+), 13 deletions(-) -- BR, HcE