From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933545AbbCRS76 (ORCPT ); Wed, 18 Mar 2015 14:59:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56577 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932812AbbCRS74 (ORCPT ); Wed, 18 Mar 2015 14:59:56 -0400 Date: Wed, 18 Mar 2015 19:59:16 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , linux-kernel@vger.kernel.org, Corey Ashford , David Ahern , Ingo Molnar , Namhyung Kim , Paul Mackerras , Peter Zijlstra Subject: Re: [PATCHv2 00/15] tools build: Move features framework into tools/build Message-ID: <20150318185916.GA13716@krava.brq.redhat.com> References: <1426064344-21737-1-git-send-email-jolsa@kernel.org> <20150318185048.GB3349@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150318185048.GB3349@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 03:50:48PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 11, 2015 at 09:58:49AM +0100, Jiri Olsa escreveu: > > hi, > > moving features detection framework from perf to 'tools/build' > > plus other minor fixes. > > > > v2 changes: > > - omitted patch 1 from original version (Ingo) > > - added features build output dump (Arnaldo) > > - better scripting in features test (Namhyung) > > - fixed test-all for pthread-attr-setaffinity-np > > - removed main_test_libbabeltrace from test-all > > - patches reordered > > > > It's also available in: > > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > > perf/build > > Ok, so using the csets from the above branch, if I do: > > [acme@ssdandy linux]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; time make O=/tmp/build/perf -C tools/perf LIBBABELTRACE_DIR=/opt/libbabeltrace/ install-bin > make: Entering directory `/home/acme/git/linux/tools/perf' > BUILD: Doing 'make -j8' parallel build > config/Makefile:423: No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR > > Auto-detecting system features: > ... dwarf: [ on ] > ... glibc: [ on ] > ... gtk2: [ on ] > ... libaudit: [ on ] > ... libbfd: [ on ] > ... libelf: [ on ] > ... libnuma: [ on ] > ... libperl: [ on ] > ... libpython: [ on ] > ... libslang: [ on ] > ... libunwind: [ OFF ] > ... libdw-dwarf-unwind: [ on ] > ... zlib: [ on ] > ... DWARF post unwind library: libdw > > And then, despite not telling anything about babeltrace being linked, > i.e. the no line above with a [ on ], we get: libbabeltrace was taken out of the default display of features as requested, because the requested interface wasn't released yet you enabled it manually via LIBBABELTRACE_DIR='...', so it got linked.. but it wont appear in the default display list anyway.. we dont have this kind of functionality yet jirka > > [acme@ssdandy linux]$ ldd ~/bin/perf | grep babel > libbabeltrace-ctf.so.1 => /opt/libbabeltrace/lib/libbabeltrace-ctf.so.1 (0x00007f5f7b758000) > libbabeltrace.so.1 => /opt/libbabeltrace/lib/libbabeltrace.so.1 (0x00007f5f7acfb000) > [acme@ssdandy linux]$ > > I.e. if a libbabeltrace-devel was installed and had what is needed to build it > in, when there would be no need for the LIBBABELTRACE_DIR above and babeltrace > wouldn't be either implicitely or explicitely specified as something we want to > build against we would not show it as a feature being built in (no > libbabeltrace: [ On ]) but would do it anyway, is that really the intention? > > I tested in fedora, where no system auto-detection fails, i.e. test-all passes, > and the result is the same. > > Ingo, can you clarify here? > > - Arnaldo