From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755937AbbCSBhy (ORCPT ); Wed, 18 Mar 2015 21:37:54 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:60754 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbbCSBhv (ORCPT ); Wed, 18 Mar 2015 21:37:51 -0400 Date: Thu, 19 Mar 2015 10:37:48 +0900 From: Simon Horman To: Geert Uytterhoeven Cc: Thomas Gleixner , Jason Cooper , Magnus Damm , linux-sh@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] irqchip: renesas-irqc: Add minimal runtime PM support Message-ID: <20150319013748.GH14051@verge.net.au> References: <1426704961-27322-1-git-send-email-geert+renesas@glider.be> <1426704961-27322-3-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426704961-27322-3-git-send-email-geert+renesas@glider.be> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 07:55:56PM +0100, Geert Uytterhoeven wrote: > This is just enough to let pm_clk_*() enable the functional clock, and > manage it for suspend/resume, if present. > Before, it was assumed enabled by the bootloader or reset state. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman > --- > drivers/irqchip/irq-renesas-irqc.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/irqchip/irq-renesas-irqc.c b/drivers/irqchip/irq-renesas-irqc.c > index 2ce2edf8ec8ec182..718f01cd1aea19f6 100644 > --- a/drivers/irqchip/irq-renesas-irqc.c > +++ b/drivers/irqchip/irq-renesas-irqc.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > > #define IRQC_IRQ_MAX 32 /* maximum 32 interrupts per driver instance */ > > @@ -180,6 +181,9 @@ static int irqc_probe(struct platform_device *pdev) > p->pdev = pdev; > platform_set_drvdata(pdev, p); > > + pm_runtime_enable(&pdev->dev); > + pm_runtime_get_sync(&pdev->dev); > + > /* get hold of manadatory IOMEM */ > io = platform_get_resource(pdev, IORESOURCE_MEM, 0); > if (!io) { > @@ -260,6 +264,8 @@ err3: > err2: > iounmap(p->iomem); > err1: > + pm_runtime_put(&pdev->dev); > + pm_runtime_disable(&pdev->dev); > kfree(p); > err0: > return ret; > @@ -275,6 +281,8 @@ static int irqc_remove(struct platform_device *pdev) > > irq_domain_remove(p->irq_domain); > iounmap(p->iomem); > + pm_runtime_put(&pdev->dev); > + pm_runtime_disable(&pdev->dev); > kfree(p); > return 0; > } > -- > 1.9.1 >