From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752596AbbCSHZf (ORCPT ); Thu, 19 Mar 2015 03:25:35 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:48739 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbbCSHZd (ORCPT ); Thu, 19 Mar 2015 03:25:33 -0400 Date: Thu, 19 Mar 2015 08:25:02 +0100 From: Peter Zijlstra To: Andrew Morton Cc: mingo@kernel.org, rusty@rustcorp.com.au, mathieu.desnoyers@efficios.com, oleg@redhat.com, paulmck@linux.vnet.ibm.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, andi@firstfloor.org, rostedt@goodmis.org, tglx@linutronix.de, Michel Lespinasse , Andrea Arcangeli , David Woodhouse , Rik van Riel Subject: Re: [PATCH 6/8] rbtree: Implement generic latch_tree Message-ID: <20150319072502.GR23123@twins.programming.kicks-ass.net> References: <20150318133626.526984618@infradead.org> <20150318134631.939369528@infradead.org> <20150318221446.14b0b04d.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150318221446.14b0b04d.akpm@linux-foundation.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 10:14:46PM -0700, Andrew Morton wrote: > On Wed, 18 Mar 2015 14:36:32 +0100 Peter Zijlstra wrote: > > > include/linux/rbtree_latch.h | 223 +++++++++++++++++++++++++++++++++++++++++++ > > Did it really need to all be inlined? Without that you get actual function calls to the less() and comp() operators. This way GCC can inline the lot even though its function pointers. The typical RB tree user open-codes all this every single time. > How much of this code is unneeded on uniprocessor? None, UP has NMIs too.