From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751867AbbCSIst (ORCPT ); Thu, 19 Mar 2015 04:48:49 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:47935 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751381AbbCSIso (ORCPT ); Thu, 19 Mar 2015 04:48:44 -0400 Date: Thu, 19 Mar 2015 09:48:41 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Sascha Hauer Cc: Mike Turquette , Stephen Boyd , YH Chen , linux-kernel@vger.kernel.org, Henry Chen , linux-mediatek@lists.infradead.org, kernel@pengutronix.de, Matthias Brugger , Yingjoe Chen , Eddie Huang , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/6] clk: make strings in parent name arrays const Message-ID: <20150319084841.GT10068@pengutronix.de> References: <1426754530-3137-1-git-send-email-s.hauer@pengutronix.de> <1426754530-3137-2-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1426754530-3137-2-git-send-email-s.hauer@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Mar 19, 2015 at 09:42:05AM +0100, Sascha Hauer wrote: > The clk functions and structs declare the parent_name arrays as > 'const char **parent_names' which means the parent name strings > are const, but the array itself is not. Use > 'const char * const * parent_names' instead which also makes > the array const. This allows us to put the parent_name arrays into > the __initconst section. > > Signed-off-by: Sascha Hauer looks sensible: Acked-by: Uwe Kleine-König It would be nice to have this for more clock types (which of course shouldn't delay this patch). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |