From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"slaoub@gmail.com" <slaoub@gmail.com>,
"luto@amacapital.net" <luto@amacapital.net>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH] x86, mce, severities: Add AMD severities function
Date: Thu, 19 Mar 2015 10:29:53 +0100 [thread overview]
Message-ID: <20150319092953.GB10860@pd.tnic> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F32A234ED@ORSMSX114.amr.corp.intel.com>
On Thu, Mar 19, 2015 at 12:01:32AM +0000, Luck, Tony wrote:
> One other thought. Instead of the run-time test to see if this is an AMD processor on every call
> to this function, would it be cleaner to:
>
> 1) Rename existing mce_severity() function to mce_severity_intel()
> 2) Declare a function pointer named mce_severity.
> 3) Assign that pointer to the _intel() or _amd() function in mce_init()
Yes, of course. We do that (or at least pretty close) in other paths
too.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-03-19 9:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 17:16 Aravind Gopalakrishnan
2015-03-17 7:42 ` Ingo Molnar
2015-03-17 9:04 ` Borislav Petkov
2015-03-17 10:11 ` Ingo Molnar
2015-03-17 10:20 ` Borislav Petkov
2015-03-17 18:41 ` Aravind Gopalakrishnan
2015-03-17 18:44 ` Borislav Petkov
2015-03-19 0:01 ` Luck, Tony
2015-03-19 9:29 ` Borislav Petkov [this message]
2015-03-19 14:41 ` Aravind Gopalakrishnan
2015-03-19 15:53 ` Borislav Petkov
2015-03-19 16:20 ` Aravind Gopalakrishnan
2015-03-19 17:15 ` Luck, Tony
2015-03-20 15:59 ` Aravind Gopalakrishnan
2015-03-20 16:03 ` Borislav Petkov
2015-03-20 17:49 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319092953.GB10860@pd.tnic \
--to=bp@alien8.de \
--cc=aravind.gopalakrishnan@amd.com \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=slaoub@gmail.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®