From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754753AbbCSJ67 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 Mar 2015 05:58:59 -0400
Received: from mga03.intel.com ([134.134.136.65]:14986 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751366AbbCSJ6z (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 Mar 2015 05:58:55 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,428,1422950400"; 
   d="scan'208";a="694427922"
Date: Thu, 19 Mar 2015 11:58:50 +0200
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Feng Kan <fkan@apm.com>
Cc: patches@apm.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-acpi@vger.kernel.org, tj@kernel.org,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH RESEND] sata: xgene: add ACPI support for APM X-Gene SATA
 ports
Message-ID: <20150319095850.GO2165@lahna.fi.intel.com>
References: <1426723435-22378-1-git-send-email-fkan@apm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426723435-22378-1-git-send-email-fkan@apm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 18, 2015 at 05:03:55PM -0700, Feng Kan wrote:
> This adds ACPI support for the APM X-Gene SATA ports. When the system
> boots using ACPI table, the SATA ports are able to configure using the
> values supplied by the ACPI table rather than the DTS.
> 
> Signed-off-by: Feng Kan <fkan@apm.com>
> Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>

One minor comment, see below. Other than that this looks good to me:

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

> ---
>  drivers/ata/ahci_xgene.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
> index 2e8bb60..2b78510 100644
> --- a/drivers/ata/ahci_xgene.c
> +++ b/drivers/ata/ahci_xgene.c
> @@ -22,6 +22,7 @@
>   * NOTE: PM support is not currently available.
>   *
>   */
> +#include <linux/acpi.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/ahci_platform.h>
> @@ -718,6 +719,14 @@ disable_resources:
>  	return rc;
>  }
>  
> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id xgene_ahci_acpi_match[] = {
> +	{ "APMC0D0D", },

I think writing the above without comma would look better:

	{ "APMC0D0D" },


> +	{ }
> +};
> +MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match);
> +#endif
> +
>  static const struct of_device_id xgene_ahci_of_match[] = {
>  	{.compatible = "apm,xgene-ahci"},
>  	{},
> @@ -730,6 +739,7 @@ static struct platform_driver xgene_ahci_driver = {
>  	.driver = {
>  		.name = DRV_NAME,
>  		.of_match_table = xgene_ahci_of_match,
> +		.acpi_match_table = ACPI_PTR(xgene_ahci_acpi_match),
>  	},
>  };
>  
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html