From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932AbbCSNM1 (ORCPT ); Thu, 19 Mar 2015 09:12:27 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35734 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbbCSNMZ (ORCPT ); Thu, 19 Mar 2015 09:12:25 -0400 Date: Thu, 19 Mar 2015 14:10:47 +0100 From: Borislav Petkov To: Steven Rostedt Cc: Xie XiuQi , akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com, gong.chen@linux.intel.com, bhelgaas@google.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, jingle.chen@huawei.com Subject: Re: [PATCH] trace, RAS: remove unnecessary const Message-ID: <20150319131047.GE11544@pd.tnic> References: <1426755004-28434-1-git-send-email-xiexiuqi@huawei.com> <20150319103330.GC11544@pd.tnic> <20150319085756.2c649e7d@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150319085756.2c649e7d@gandalf.local.home> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 08:57:56AM -0400, Steven Rostedt wrote: > That's a bit of a stretch. But sure, there's no real downside to having > it, except that it makes one take a double take when seeing it, and > thinking about why it would even be needed (like I did). Why? It simply declares the contract that this argument won't be changed. And if there's no downside, there's no need to do anything here. > I think you had the crazy fantasy with the above patch! Wasn't me. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --