From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753748AbbCSNtf (ORCPT ); Thu, 19 Mar 2015 09:49:35 -0400 Received: from skprod2.natinst.com ([130.164.80.23]:43139 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751394AbbCSNte (ORCPT ); Thu, 19 Mar 2015 09:49:34 -0400 Date: Thu, 19 Mar 2015 08:49:11 -0500 From: Josh Cartwright To: Michal Simek Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, S?ren Brinkmann Subject: Re: [PATCH 2/2] ARM: zynq: drop use of slcr_unlock in zynq_slcr_system_restart Message-ID: <20150319134911.GC23626@jcartwri.amer.corp.natinst.com> References: <1426772033-29277-1-git-send-email-joshc@ni.com> <1426772033-29277-2-git-send-email-joshc@ni.com> MIME-Version: 1.0 In-Reply-To: <1426772033-29277-2-git-send-email-joshc@ni.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6|November 21, 2013) at 03/19/2015 08:49:11 AM, Serialize by Router on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6|November 21, 2013) at 03/19/2015 08:49:11 AM, Serialize complete at 03/19/2015 08:49:11 AM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-03-19_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ugh. On Thu, Mar 19, 2015 at 08:33:53AM -0500, Josh Cartwright wrote: > The SLCR is unconditionally unlocked early on boot in zynq_slcr_init() > and not unlocked. As such, it is not necessary to explicitly unlock in ^ever re-locked. Can you fix this up when you apply? Thanks, Josh