From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755385AbbCSOFV (ORCPT ); Thu, 19 Mar 2015 10:05:21 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48221 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751794AbbCSOFP (ORCPT ); Thu, 19 Mar 2015 10:05:15 -0400 Date: Thu, 19 Mar 2015 15:05:11 +0100 From: Greg KH To: Darshana Padmadas Cc: outreachy-kernel@googlegroups.com, jic23@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH] iio: adc: Call uninitialized_var for raw_sample Message-ID: <20150319140511.GA7046@kroah.com> References: <1426772061-20753-1-git-send-email-darshanapadmadas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426772061-20753-1-git-send-email-darshanapadmadas@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 07:04:21PM +0530, Darshana Padmadas wrote: > This patch calls uninitialized_var function for uninitialized > variable raw_sample. This error was reported by the static > analysis tool, cppcheck. > > Signed-off-by: Darshana Padmadas > --- > drivers/iio/adc/ad_sigma_delta.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c > index d10bd0c..f0bbf3c 100644 > --- a/drivers/iio/adc/ad_sigma_delta.c > +++ b/drivers/iio/adc/ad_sigma_delta.c > @@ -248,7 +248,8 @@ int ad_sigma_delta_single_conversion(struct iio_dev *indio_dev, > const struct iio_chan_spec *chan, int *val) > { > struct ad_sigma_delta *sigma_delta = iio_device_get_drvdata(indio_dev); > - unsigned int sample, raw_sample; > + unsigned int sample; > + unsigned int uninitialized_var(raw_sample); I don't understand, what exactly is this "fixing"? And note, cppcheck is known to give you lots of false warnings / errors, be very careful when using it. Some kernel developers refuse to take patches that mention it given that it has been wrong so many times in the past. thanks, greg k-h