From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752206AbbCSPPq (ORCPT ); Thu, 19 Mar 2015 11:15:46 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49488 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbbCSPPp (ORCPT ); Thu, 19 Mar 2015 11:15:45 -0400 Date: Thu, 19 Mar 2015 16:15:40 +0100 From: Greg Kroah-Hartman To: Brian Russell Cc: "Hans J. Koch" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v7] uio: Fix uio driver to refcount device Message-ID: <20150319151540.GB9734@kroah.com> References: <550AE5AB.4060906@brocade.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <550AE5AB.4060906@brocade.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 03:05:15PM +0000, Brian Russell wrote: > Protect uio driver from its owner being unplugged while there are open fds. > Embed struct device in struct uio_device, use refcounting on device, free uio_device on release. > info struct passed in uio_register_device can be freed on unregister, so null out the field in > uio_unregister_device and check accesses. Minor nit, changelogs need to be linewrapped at 72 columns, if your editor is sane, it should have warned you about this :) thanks, greg k-h