From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751218AbbCSTwd (ORCPT ); Thu, 19 Mar 2015 15:52:33 -0400 Received: from smtprelay0070.hostedemail.com ([216.40.44.70]:45863 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750885AbbCSTwb (ORCPT ); Thu, 19 Mar 2015 15:52:31 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1434:1437:1515:1516:1518:1535:1544:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2898:3138:3139:3140:3141:3142:3353:3865:3866:3867:3868:3870:3871:3872:3873:4250:5007:6119:6248:6261:6678:7875:7903:7904:9010:10004:10848:10967:11026:11232:11473:11657:11658:11914:12043:12296:12438:12517:12519:12555:12663:12740:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: judge45_6d09901b73757 X-Filterd-Recvd-Size: 5232 Date: Thu, 19 Mar 2015 15:52:28 -0400 From: Steven Rostedt To: Philipp Zabel Cc: Mark Brown , kernel@pengutronix.de, Pankaj Dubey , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace events Message-ID: <20150319155228.12b834e9@gandalf.local.home> In-Reply-To: <1425894502.3152.12.camel@pengutronix.de> References: <1425651415-31590-1-git-send-email-p.zabel@pengutronix.de> <20150307105747.GC28806@sirena.org.uk> <1425894502.3152.12.camel@pengutronix.de> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org /me decides to continue the "reply backwards" method. On Mon, 09 Mar 2015 10:48:22 +0100 Philipp Zabel wrote: > Am Samstag, den 07.03.2015, 10:57 +0000 schrieb Mark Brown: > > On Fri, Mar 06, 2015 at 03:16:55PM +0100, Philipp Zabel wrote: > > > > > #include > > > -#include > > > > > > #include "internal.h" > > > > > > +#include > > > + > > > > The change is basically OK but the above is a bit too funky for my > > taste - it feels like it's asking for annoying compile breakage if > > anyone changes anything. I'd be more inclined to move the header > > somewhere where the events stuff can see it than do this. > > Good point. As I see it I have three possiblities now: > > a) Just #include "../../../drivers/base/regmap/internal.h" in > include/trace/events/regmap.h > > b) Move drivers/base/regmap/internal.h to > include/linux/regmap-internal.h and > #include in include/trace/events/regmap.h > > c) Move include/trace/events/regmap.h to drivers/base/regmap/trace.h > and just #include "internal.h" in drivers/base/regmap/trace.h > > Which, if any, of these options would you prefer? Here is an > unscientific survey: > > a) $ git grep "#include \"\.\." include/ > include/linux/libfdt.h:#include "../../scripts/dtc/libfdt/fdt.h" > include/linux/libfdt.h:#include "../../scripts/dtc/libfdt/libfdt.h" > include/xen/interface/io/vscsiif.h:#include "../grant_table.h" > > b) $ find include/ -name "*internal.h" > include/linux/timekeeper_internal.h > > c) $ find drivers/ -name trace.h > drivers/net/wireless/ath/ath10k/trace.h > drivers/net/wireless/ath/trace.h > drivers/net/wireless/ath/wil6210/trace.h > drivers/net/wireless/ath/ath5k/trace.h > drivers/net/wireless/ath/ath6kl/trace.h > drivers/usb/dwc3/trace.h > drivers/misc/cxl/trace.h > > a) and b) aren't very common, and c) is mostly used by driver-level, not > subsystem-level trace events. I'm not sure what you mean be driver-level vs subsystem-level. How is this a subsystem level as regmap happens to be in the drivers code. Also, if you want a more thorough list, try this: $ find drivers/ -name "*.h" ! -type d | xargs grep -l "TRACE_SYSTEM" drivers/misc/cxl/trace.h drivers/usb/host/xhci-trace.h drivers/usb/dwc3/trace.h drivers/android/binder_trace.h drivers/gpu/drm/drm_trace.h drivers/gpu/drm/i915/i915_trace.h drivers/gpu/drm/radeon/radeon_trace.h drivers/staging/android/trace/sync.h drivers/mtd/devices/docg3.h drivers/net/wireless/brcm80211/brcmsmac/brcms_trace_events.h drivers/net/wireless/brcm80211/brcmfmac/tracepoint.h drivers/net/wireless/iwlwifi/iwl-devtrace.h drivers/net/wireless/ath/trace.h drivers/net/wireless/ath/ath6kl/trace.h drivers/net/wireless/ath/ath5k/trace.h drivers/net/wireless/ath/wil6210/trace.h drivers/net/wireless/ath/ath10k/trace.h And looking outside of drivers and trace: $ find . -path ./include/trace -prune -o -name drivers -prune -o -name '*.h' -print | xargs grep -l TRACE_SYSTEM ./sound/core/pcm_trace.h ./sound/pci/hda/hda_intel_trace.h ./sound/pci/hda/hda_trace.h ./kernel/trace/trace_benchmark.h ./kernel/trace/trace_events_filter_test.h ./arch/arm64/kernel/trace-events-emulation.h ./arch/arm64/kvm/trace.h ./arch/x86/kernel/vsyscall_trace.h ./arch/x86/include/asm/trace/exceptions.h ./arch/x86/include/asm/trace/irq_vectors.h ./arch/x86/kvm/mmutrace.h ./arch/x86/kvm/trace.h ./arch/s390/kvm/trace.h ./arch/s390/kvm/trace-s390.h ./arch/powerpc/platforms/cell/spufs/sputrace.h ./arch/powerpc/include/asm/trace.h ./arch/powerpc/kvm/trace.h ./arch/powerpc/kvm/trace_hv.h ./arch/powerpc/kvm/trace_pr.h ./arch/powerpc/kvm/trace_booke.h ./arch/mips/kvm/trace.h ./arch/arm/kvm/trace.h ./include/ras/ras_event.h ./net/mac80211/trace.h ./net/wireless/trace.h ./samples/trace_events/trace-events-sample.h ./fs/ocfs2/ocfs2_trace.h ./fs/nfs/nfstrace.h ./fs/nfs/nfs4trace.h ./fs/nfsd/trace.h ./fs/gfs2/trace_gfs2.h ./fs/xfs/xfs_trace.h -- Steve