From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932144AbbCSQqt (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 Mar 2015 12:46:49 -0400
Received: from mail.skyhub.de ([78.46.96.112]:59404 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932067AbbCSQqo (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 Mar 2015 12:46:44 -0400
Date: Thu, 19 Mar 2015 17:45:06 +0100
From: Borislav Petkov <bp@alien8.de>
To: Tejun Heo <tj@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Doug Thompson <dougthompson@xmission.com>,
        linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        Olof Johansson <olof@lixom.net>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Luis R . Rodriguez" <mcgrof@suse.com>
Subject: Re: [PATCH 3/3] EDAC: amd64_edac: decide if driver can load
 successfully early.
Message-ID: <20150319164506.GJ11715@pd.tnic>
References: <1426726150-983-1-git-send-email-dmitry.torokhov@gmail.com>
 <1426726150-983-4-git-send-email-dmitry.torokhov@gmail.com>
 <20150319094054.GC10860@pd.tnic>
 <20150319152957.GI25365@htj.duckdns.org>
 <20150319153505.GD11715@pd.tnic>
 <20150319155253.GA30732@dtor-ws>
 <20150319155953.GF11715@pd.tnic>
 <20150319161226.GC30732@dtor-ws>
 <20150319162301.GH11715@pd.tnic>
 <20150319163330.GN25365@htj.duckdns.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150319163330.GN25365@htj.duckdns.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 19, 2015 at 12:33:30PM -0400, Tejun Heo wrote:
> Please stop shell scripting in your ->probe() in kernel.

I don't think you understand me: I'm not going to shell script in my
->probe() function. This is what I'm going to do:

init():

	for each northbridge {
		check if northbridge has ecc;
	}

	if no northbridge has ecc {
		return;
	}

	pci_register_driver();

Now this is clean and doesn't violate any models. It is basically a
check whether the driver should load or not. What's wrong with that, for
chrissake?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--