From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755278AbbCSQtS (ORCPT ); Thu, 19 Mar 2015 12:49:18 -0400 Received: from mail-vc0-f175.google.com ([209.85.220.175]:55372 "EHLO mail-vc0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932214AbbCSQtN (ORCPT ); Thu, 19 Mar 2015 12:49:13 -0400 Date: Thu, 19 Mar 2015 12:49:08 -0400 From: Tejun Heo To: Borislav Petkov Cc: Dmitry Torokhov , Doug Thompson , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, Mauro Carvalho Chehab , Tetsuo Handa , Olof Johansson , Arjan van de Ven , Greg Kroah-Hartman , "Luis R . Rodriguez" Subject: Re: [PATCH 3/3] EDAC: amd64_edac: decide if driver can load successfully early. Message-ID: <20150319164908.GO25365@htj.duckdns.org> References: <1426726150-983-4-git-send-email-dmitry.torokhov@gmail.com> <20150319094054.GC10860@pd.tnic> <20150319152957.GI25365@htj.duckdns.org> <20150319153505.GD11715@pd.tnic> <20150319155253.GA30732@dtor-ws> <20150319155953.GF11715@pd.tnic> <20150319161226.GC30732@dtor-ws> <20150319162301.GH11715@pd.tnic> <20150319163330.GN25365@htj.duckdns.org> <20150319164506.GJ11715@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150319164506.GJ11715@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 05:45:06PM +0100, Borislav Petkov wrote: > Now this is clean and doesn't violate any models. It is basically a > check whether the driver should load or not. What's wrong with that, for > chrissake? That it's repeating iteration performed at bus layer? How is that not a layering violation? Just stop. Don't do it. Nothing needs to be done. Drop it. You're solving a non-existing problem. -- tejun