From: Tejun Heo <tj@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Doug Thompson <dougthompson@xmission.com>,
linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Olof Johansson <olof@lixom.net>,
Arjan van de Ven <arjan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Luis R . Rodriguez" <mcgrof@suse.com>
Subject: Re: [PATCH 3/3] EDAC: amd64_edac: decide if driver can load successfully early.
Date: Thu, 19 Mar 2015 13:03:39 -0400 [thread overview]
Message-ID: <20150319170339.GP25365@htj.duckdns.org> (raw)
In-Reply-To: <20150319165619.GL11715@pd.tnic>
On Thu, Mar 19, 2015 at 05:56:20PM +0100, Borislav Petkov wrote:
> I don't see anything wrong with that and I don't see how that would
> repeat any iteration...
Just don't do it. It makes the driver behave differently from others
for no good reason. Driver being loaded or not doesn't indicate
anything anymore other than the code is loaded and you're adding
complexity to just make it more confusing and you don't have good
enough technical reasons to justify the deviation. What are you even
fighting for?
--
tejun
next prev parent reply other threads:[~2015-03-19 17:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 0:49 [RFC/RFT] amd64_edac: avoid doing post-probe setup Dmitry Torokhov
2015-03-19 0:49 ` [PATCH 1/3] EDAC: amd64: stop allocating ecc settings separately Dmitry Torokhov
2015-03-19 0:49 ` [PATCH 2/3] EDAC: amd64_edac: clean up remove_one_instance() Dmitry Torokhov
2015-03-19 0:49 ` [PATCH 3/3] EDAC: amd64_edac: decide if driver can load successfully early Dmitry Torokhov
2015-03-19 9:40 ` Borislav Petkov
2015-03-19 15:29 ` Tejun Heo
2015-03-19 15:35 ` Borislav Petkov
2015-03-19 15:52 ` Dmitry Torokhov
2015-03-19 15:59 ` Borislav Petkov
2015-03-19 16:12 ` Dmitry Torokhov
2015-03-19 16:23 ` Borislav Petkov
2015-03-19 16:33 ` Tejun Heo
2015-03-19 16:45 ` Borislav Petkov
2015-03-19 16:49 ` Tejun Heo
2015-03-19 16:56 ` Borislav Petkov
2015-03-19 17:03 ` Tejun Heo [this message]
2015-03-19 17:04 ` Borislav Petkov
2015-03-19 17:10 ` Tejun Heo
2015-03-19 17:15 ` Tejun Heo
2015-03-19 17:27 ` Borislav Petkov
2015-03-19 17:47 ` Tejun Heo
2015-03-19 17:54 ` Borislav Petkov
2015-03-19 18:05 ` Tejun Heo
2015-03-19 16:52 ` Dmitry Torokhov
2015-03-19 17:09 ` Tejun Heo
2015-03-19 15:55 ` Tejun Heo
2015-03-19 16:01 ` Borislav Petkov
2015-03-19 16:12 ` Tejun Heo
2015-03-19 16:57 ` Dmitry Torokhov
2015-03-19 17:22 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319170339.GP25365@htj.duckdns.org \
--to=tj@kernel.org \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=dmitry.torokhov@gmail.com \
--cc=dougthompson@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=mchehab@osg.samsung.com \
--cc=olof@lixom.net \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome