From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751480AbbCTJMJ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 Mar 2015 05:12:09 -0400
Received: from casper.infradead.org ([85.118.1.10]:37683 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750913AbbCTJMF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Mar 2015 05:12:05 -0400
Date: Fri, 20 Mar 2015 10:11:53 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: mingo@kernel.org, mathieu.desnoyers@efficios.com, oleg@redhat.com,
        paulmck@linux.vnet.ibm.com, torvalds@linux-foundation.org,
        linux-kernel@vger.kernel.org, andi@firstfloor.org, rostedt@goodmis.org,
        tglx@linutronix.de, Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 3/8] module, jump_label: Fix module locking
Message-ID: <20150320091153.GW23123@twins.programming.kicks-ass.net>
References: <20150318133626.526984618@infradead.org>
 <20150318134631.743042205@infradead.org>
 <87egokjnv2.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87egokjnv2.fsf@rustcorp.com.au>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 20, 2015 at 02:56:25PM +1030, Rusty Russell wrote:
> > +static inline bool address_in_module(unsigned long addr, struct module *mod)

> Using __module_address() for this was just plain weird in the first
> place.  How about:
> 
>         if (within_module(iter->key, mod))
> 

Oh hey, look at that ;-) /me fixes.