From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751995AbbCTKMX (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 Mar 2015 06:12:23 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:36267 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751349AbbCTKMV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Mar 2015 06:12:21 -0400
Date: Fri, 20 Mar 2015 11:12:10 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] irq_work: Fix build failure when CONFIG_IRQ_WORK not
 defined
Message-ID: <20150320101210.GX23123@twins.programming.kicks-ass.net>
References: <20150319101851.4d224d9b@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150319101851.4d224d9b@gandalf.local.home>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 19, 2015 at 10:18:51AM -0400, Steven Rostedt wrote:
> When CONFIG_IRQ_WORK is not defined (difficult to do, as it also
> requires CONFIG_PRINTK not to be defined), we get a build failure:
> 
> kernel/built-in.o: In function `flush_smp_call_function_queue':
> kernel/smp.c:263: undefined reference to `irq_work_run'
> kernel/smp.c:263: undefined reference to `irq_work_run'
> Makefile:933: recipe for target 'vmlinux' failed
> 
> Simplest thing to do is to make irq_work_run() a nop when not set.
> 
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Thanks!