From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752538AbbCTOna (ORCPT ); Fri, 20 Mar 2015 10:43:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40827 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752375AbbCTOmy (ORCPT ); Fri, 20 Mar 2015 10:42:54 -0400 Date: Fri, 20 Mar 2015 14:04:19 +0100 From: Greg KH To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: Amitoj Kaur Chawla , sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sm750fb: Fix Comment and if else braces Message-ID: <20150320130419.GB23287@kroah.com> References: <20150319180556.GA12241@amitoj-Inspiron-3542> <550B11C0.1030300@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <550B11C0.1030300@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 08:13:20PM +0200, Giedrius Statkevičius wrote: > Hi Amitoj Kaur Chawla, > > On 2015.03.19 20:05, Amitoj Kaur Chawla wrote: > > The edits have been made to add a space before the comment and the errors in > > braces in the if-else statements. > > Previously in commit 2d34f53f1065878cd881ac61a183f8e836583d51, removed > > the C99 comments and errors in if-else indentation and braces. > > The previous patch isn't in the git repo yet so it doesn't have a commit > id thus this one is wrong. You should've just made a v2 and made that > change. I recommend you to look over this: > http://kernelnewbies.org/FirstKernelPatch Just remove the HEAD commit in > your local git repo, add that space and then when using `git > format-patch` use the "--subject-prefix" option to add that it's a > second version. Then after "---" you can say what was changed in the > second version. For example (I'm sure you can think of a better one!): > > Signed-off-by: ... > --- > v2: added a space after a statement in a line where a coding style error > was fixed. > > drivers/... Yes, please resend both of these. thanks, greg k-h