From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751734AbbCTNhp (ORCPT ); Fri, 20 Mar 2015 09:37:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33542 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbbCTNhn (ORCPT ); Fri, 20 Mar 2015 09:37:43 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH] m88ts2022: Nested loops shouldn't use the same index variable From: David Howells To: crope@iki.fi Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Date: Fri, 20 Mar 2015 13:37:38 +0000 Message-ID: <20150320133738.19894.45270.stgit@warthog.procyon.org.uk> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are a pair of nested loops inside m88ts2022_cmd() that use the same index variable, but for different things. Split the variable. Signed-off-by: David Howells --- drivers/media/tuners/m88ts2022.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/tuners/m88ts2022.c b/drivers/media/tuners/m88ts2022.c index 066e543..cdf9fe5 100644 --- a/drivers/media/tuners/m88ts2022.c +++ b/drivers/media/tuners/m88ts2022.c @@ -21,7 +21,7 @@ static int m88ts2022_cmd(struct m88ts2022_dev *dev, int op, int sleep, u8 reg, u8 mask, u8 val, u8 *reg_val) { - int ret, i; + int ret, i, j; unsigned int utmp; struct m88ts2022_reg_val reg_vals[] = { {0x51, 0x1f - op}, @@ -35,9 +35,9 @@ static int m88ts2022_cmd(struct m88ts2022_dev *dev, int op, int sleep, u8 reg, "i=%d op=%02x reg=%02x mask=%02x val=%02x\n", i, op, reg, mask, val); - for (i = 0; i < ARRAY_SIZE(reg_vals); i++) { - ret = regmap_write(dev->regmap, reg_vals[i].reg, - reg_vals[i].val); + for (j = 0; j < ARRAY_SIZE(reg_vals); j++) { + ret = regmap_write(dev->regmap, reg_vals[j].reg, + reg_vals[j].val); if (ret) goto err; }