From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbbCTVJs (ORCPT ); Fri, 20 Mar 2015 17:09:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53318 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbbCTVJp (ORCPT ); Fri, 20 Mar 2015 17:09:45 -0400 Date: Fri, 20 Mar 2015 14:09:43 -0700 From: Andrew Morton To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Jan Kara , David Howells , Lino Sanfilippo , Eric Paris Subject: Re: [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send_event() Message-Id: <20150320140943.9cca246285c4fa21b7621872@linux-foundation.org> In-Reply-To: <1426884968-1747-1-git-send-email-fabf@skynet.be> References: <1426884968-1747-1-git-send-email-fabf@skynet.be> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Mar 2015 21:56:08 +0100 Fabian Frederick wrote: > ltp/fanotify02 was locked since commit 66ba93c0d7fe > ("fanotify: don't set FAN_ONDIR implicitly on a marks ignored mask") What does "ltp/fanotify02 was locked" mean? That this particular test failed to exit, or...? > --- a/fs/notify/fanotify/fanotify.c > +++ b/fs/notify/fanotify/fanotify.c > @@ -140,8 +140,8 @@ static bool fanotify_should_send_event(struct fsnotify_mark *inode_mark, > } > > if (d_is_dir(path->dentry) && > - !(marks_mask & FS_ISDIR & ~marks_ignored_mask)) > - return false; > + (marks_mask & FS_ISDIR & ~marks_ignored_mask)) > + return true; Should that be (marks_mask & FS_ISDIR & marks_ignored_mask)?