From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990AbbCTUwJ (ORCPT ); Fri, 20 Mar 2015 16:52:09 -0400 Received: from mail.kernel.org ([198.145.29.136]:45457 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbbCTUwH (ORCPT ); Fri, 20 Mar 2015 16:52:07 -0400 Date: Fri, 20 Mar 2015 13:52:01 -0700 From: Jaegeuk Kim To: Taesoo Kim Cc: cm224.lee@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu, csong84@gatech.edu Subject: Re: [PATCH 1/1] f2fs: correctly check empty xattr key Message-ID: <20150320205201.GC19413@jaegeuk-mac02.mot.com> References: <1426825147-26981-1-git-send-email-tsgatesv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426825147-26981-1-git-send-email-tsgatesv@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Taesoo, On Fri, Mar 20, 2015 at 12:19:07AM -0400, Taesoo Kim wrote: > When xattr name (key) is empty (""), correctly return -EINVAL > error. xattr_advise_set/get() seem to make the same mistake. The intention here is to disallow any xattr name, since this is used to get or set the i_advise value by users. Thanks, > > Signed-off-by: Taesoo Kim > --- > fs/f2fs/xattr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c > index 5072bf9..6b1fbc4 100644 > --- a/fs/f2fs/xattr.c > +++ b/fs/f2fs/xattr.c > @@ -132,7 +132,7 @@ static int f2fs_xattr_advise_get(struct dentry *dentry, const char *name, > { > struct inode *inode = dentry->d_inode; > > - if (strcmp(name, "") != 0) > + if (strcmp(name, "") == 0) > return -EINVAL; > > *((char *)buffer) = F2FS_I(inode)->i_advise; > @@ -144,7 +144,7 @@ static int f2fs_xattr_advise_set(struct dentry *dentry, const char *name, > { > struct inode *inode = dentry->d_inode; > > - if (strcmp(name, "") != 0) > + if (strcmp(name, "") == 0) > return -EINVAL; > if (!inode_owner_or_capable(inode)) > return -EPERM; > -- > 2.3.3