From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbbCTVR0 (ORCPT ); Fri, 20 Mar 2015 17:17:26 -0400 Received: from mailgw1.uni-kl.de ([131.246.120.220]:58216 "EHLO mailgw1.uni-kl.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752032AbbCTVRX convert rfc822-to-8bit (ORCPT ); Fri, 20 Mar 2015 17:17:23 -0400 Date: Fri, 20 Mar 2015 22:16:50 +0100 From: Thomas =?UTF-8?B?TmllZGVycHLDvG0=?= To: Maxime Ripard Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, kernel@pengutronix.de, shawn.guo@linaro.org, robh+dt@kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 07/10] fbdev: ssd1307fb: Add a module parameter to set the refresh rate Message-ID: <20150320221650.7be5f4b7@maestro.intranet> In-Reply-To: <20150319131824.GB4255@lukather> References: <1423261694-5939-1-git-send-email-niederp@physik.uni-kl.de> <1426525918-12745-1-git-send-email-niederp@physik.uni-kl.de> <1426525918-12745-8-git-send-email-niederp@physik.uni-kl.de> <20150319131824.GB4255@lukather> Organization: TU Kaiserslautern X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.26; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Thu, 19 Mar 2015 14:18:24 +0100 schrieb Maxime Ripard : > On Mon, Mar 16, 2015 at 06:11:55PM +0100, Thomas Niederprüm wrote: > > This patch adds the module parameter "refreshrate" to set delay for > > the deferred io. The refresh rate is given in units of Hertz. The > > default refresh rate is 1 Hz. The refresh rate set through the > > newly introduced parameter applies to all instances of the driver > > and for now it is not possible to change it individually. > > > > Signed-off-by: Thomas Niederprüm > > --- > > drivers/video/fbdev/ssd1307fb.c | 23 +++++++++++++++++------ > > 1 file changed, 17 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/video/fbdev/ssd1307fb.c > > b/drivers/video/fbdev/ssd1307fb.c index 6fecec8..8a8d305 100644 > > --- a/drivers/video/fbdev/ssd1307fb.c > > +++ b/drivers/video/fbdev/ssd1307fb.c > > @@ -42,6 +42,11 @@ > > #define SSD1307FB_SET_COM_PINS_CONFIG 0xda > > #define SSD1307FB_SET_VCOMH 0xdb > > > > +#define REFRASHRATE 1 > > + > > +static u_int refreshrate = REFRASHRATE; > > s/REFRASH/REFRESH/ :) It's written the wrong way and the right way in the same line :) Of course I will fix that. Thanks, Thomas