From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751759AbbCVCO4 (ORCPT ); Sat, 21 Mar 2015 22:14:56 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:42469 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265AbbCVCOz (ORCPT ); Sat, 21 Mar 2015 22:14:55 -0400 Date: Sat, 21 Mar 2015 22:14:50 -0400 (EDT) Message-Id: <20150321.221450.2007372852150941507.davem@davemloft.net> To: linux@roeck-us.net Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/18] net: dsa: HW bridging, EEE support From: David Miller In-Reply-To: <550DFADE.1080209@roeck-us.net> References: <1426952815-4642-1-git-send-email-linux@roeck-us.net> <20150321.184817.575148530596089433.davem@davemloft.net> <550DFADE.1080209@roeck-us.net> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guenter Roeck Date: Sat, 21 Mar 2015 16:12:30 -0700 > Yes, agreed. It is on the to-do list. Should we be more aggressive ? > Since I'll have to resubmit anyway, we could start by adding defines > for all constants used in this patch set, not just some of them. As long as you'll really take care of this afterwards, you can take care of the defines after this series is integrated.