From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751300AbbCUGMZ (ORCPT ); Sat, 21 Mar 2015 02:12:25 -0400 Received: from mail.skyhub.de ([78.46.96.112]:37204 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbbCUGMX (ORCPT ); Sat, 21 Mar 2015 02:12:23 -0400 Date: Sat, 21 Mar 2015 07:10:42 +0100 From: Borislav Petkov To: Aravind Gopalakrishnan Cc: "Luck, Tony" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "slaoub@gmail.com" , "luto@amacapital.net" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH V2 2/2] x86, mce, severities: Define mce_severity function pointer Message-ID: <20150321061042.GA27221@pd.tnic> References: <1426869068-4155-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1426869068-4155-3-git-send-email-Aravind.Gopalakrishnan@amd.com> <3908561D78D1C84285E8C5FCA982C28F32A267D3@ORSMSX114.amr.corp.intel.com> <550CD8EE.4090504@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <550CD8EE.4090504@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 20, 2015 at 09:35:26PM -0500, Aravind Gopalakrishnan wrote: > Other function pointers in the mce code like unexpected_machine_check > and default_threshold_interrupt are assigned to the respective > function pointers when they are defined. The "WTF?!" would still fire and we don't want that. Also, I'm not sure about returning MCE_PANIC_SEVERITY by default. I mean, the code for !(Intel || AMD) has worked just fine with the original severities, i.e., mce_severity_intel() now. So maybe we should assign mce_severity_intel() on static init of the mce_severity pointer and override it only on AMD... This keeps the old behaviour for other machines, in the manner of letting sleeping dogs lie... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --