From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751466AbbCUPYt (ORCPT ); Sat, 21 Mar 2015 11:24:49 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:54094 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbbCUPYq (ORCPT ); Sat, 21 Mar 2015 11:24:46 -0400 Date: Sat, 21 Mar 2015 16:21:03 +0100 From: Andrew Lunn To: Mathieu Olivari Cc: davem@davemloft.net, f.fainelli@gmail.com, linux@roeck-us.net, jiri@resnulli.us, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: make NET_DSA manually selectable from the config Message-ID: <20150321152103.GB11720@lunn.ch> References: <1426901463-31913-1-git-send-email-mathieu@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426901463-31913-1-git-send-email-mathieu@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 20, 2015 at 06:31:03PM -0700, Mathieu Olivari wrote: > Change bd76a116707bd2381da36cf7c3183df11293f1d6 made all DSA drivers > depend on NET_DSA rather than selecting them. However, as the only way > to select this option was to actually select a driver, it made DSA > impossible to enable at all. > > This patch adds an explicit entry which the user will have to enable > prior selecting a driver. > > Signed-off-by: Mathieu Olivari A bit late, but Review-by: Andrew Lunn Andrew > --- > net/dsa/Kconfig | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig > index 087e654..4f3cce1 100644 > --- a/net/dsa/Kconfig > +++ b/net/dsa/Kconfig > @@ -5,9 +5,12 @@ config HAVE_NET_DSA > # Drivers must select NET_DSA and the appropriate tagging format > > config NET_DSA > - tristate > + tristate "Distributed Switch Architecture" > depends on HAVE_NET_DSA && NET_SWITCHDEV > select PHYLIB > + ---help--- > + Say Y if you want to enable support for the hardware switches supported > + by the Distributed Switch Architecture. > > if NET_DSA > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html