From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751591AbbCURHM (ORCPT ); Sat, 21 Mar 2015 13:07:12 -0400 Received: from zeroeth.unpythonic.net ([162.243.242.154]:51525 "EHLO zeroeth.unpythonic.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbbCURHK (ORCPT ); Sat, 21 Mar 2015 13:07:10 -0400 Date: Sat, 21 Mar 2015 12:07:04 -0500 From: Jeff Epler To: Sanidhya Kashyap Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu Subject: Re: [PATCH] afs: kstrdup() memory handling Message-ID: <20150321170703.GA17049@unpythonic.net> References: <1426956609-27273-1-git-send-email-sanidhya.gatech@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426956609-27273-1-git-send-email-sanidhya.gatech@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 21, 2015 at 12:50:09PM -0400, Sanidhya Kashyap wrote: > + if (new_opts) > + goto error_out; Missing "!"? Jeff