From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751804AbbCUWJJ (ORCPT ); Sat, 21 Mar 2015 18:09:09 -0400 Received: from 200.180.216.87.static.jazztel.es ([87.216.180.200]:34446 "HELO mail.sysvalve.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751650AbbCUWJG (ORCPT ); Sat, 21 Mar 2015 18:09:06 -0400 Date: Sat, 21 Mar 2015 23:09:02 +0100 From: =?iso-8859-1?Q?L=2E_Alberto_Gim=E9nez?= To: Peter Hurley Cc: linux-kernel@vger.kernel.org, Andy Whitcroft , Joe Perches Subject: Re: [PATCH] checkpatch.pl: Add warning for harmful goto labels Message-ID: <20150321220902.GB14583@bart.evergreen.loc> References: <1426972574-12199-1-git-send-email-agimenez@sysvalve.es> <550DE570.4060803@hurleysoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <550DE570.4060803@hurleysoftware.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 21, 2015 at 05:41:04PM -0400, Peter Hurley wrote: > Hi Alberto, > > On 03/21/2015 05:16 PM, L. Alberto Giménez wrote: > > Issue a warning for too broad goto labels that may make the code to > > follow the wrong exit path, thus causing hard to debug bugs. > > What compiler allowed duplicate goto labels? Humans are bad at following code paths, and making modifications to such code may lead to errors if the code is not descriptive enough, please check my reply to Richard for an explanation. Regards, -- L. Alberto Giménez GnuPG key ID 0xDD4E27AB