From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752007AbbCVWYK (ORCPT ); Sun, 22 Mar 2015 18:24:10 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:49532 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbbCVWYJ (ORCPT ); Sun, 22 Mar 2015 18:24:09 -0400 Date: Sun, 22 Mar 2015 18:24:07 -0400 (EDT) Message-Id: <20150322.182407.1915654260904903040.davem@davemloft.net> To: andrew@lunn.ch Cc: linux@roeck-us.net, netdev@vger.kernel.org, f.fainelli@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/18] net: dsa: mv88e6xxx: Add Hardware bridging support From: David Miller In-Reply-To: <20150322200600.GD15025@lunn.ch> References: <1426952815-4642-1-git-send-email-linux@roeck-us.net> <1426952815-4642-9-git-send-email-linux@roeck-us.net> <20150322200600.GD15025@lunn.ch> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 22 Mar 2015 15:24:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Lunn Date: Sun, 22 Mar 2015 21:06:00 +0100 > Hi Guenter > >> +static int _mv88e6xxx_atu_cmd(struct dsa_switch *ds, int fid, u16 cmd) >> +{ >> + int ret; >> + >> + ret = _mv88e6xxx_reg_write(ds, REG_GLOBAL, 0x01, fid); >> + if (ret < 0) >> + return ret; > > Please could you check this. I think register 0x01 here is wrong. I > think you want 0x0b, the ATU Operations register? Just want to mention that register mnenomics would have made this bug more obvious :-)