From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753449AbbCWTQV (ORCPT ); Mon, 23 Mar 2015 15:16:21 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:57371 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753044AbbCWTQQ (ORCPT ); Mon, 23 Mar 2015 15:16:16 -0400 Date: Mon, 23 Mar 2015 15:16:13 -0400 (EDT) Message-Id: <20150323.151613.1149103262130397921.davem@davemloft.net> To: john@stoffel.org Cc: david.ahern@oracle.com, torvalds@linux-foundation.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpicco@meloft.net Subject: Re: 4.0.0-rc4: panic in free_block From: David Miller In-Reply-To: <21776.17527.912997.355420@quad.stoffel.home> References: <20150322.221906.1670737065885267482.davem@davemloft.net> <20150323.122530.812870422534676208.davem@davemloft.net> <21776.17527.912997.355420@quad.stoffel.home> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 23 Mar 2015 12:16:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "John Stoffel" Date: Mon, 23 Mar 2015 12:51:03 -0400 > Would it make sense to have some memmove()/memcopy() tests on bootup > to catch problems like this? I know this is a strange case, and > probably not too common, but how hard would it be to wire up tests > that go through 1 to 128 byte memmove() on bootup to make sure things > work properly? > > This seems like one of those critical, but subtle things to be > checked. And doing it only on bootup wouldn't slow anything down and > would (ideally) automatically get us coverage when people add new > archs or update the code. One of two things is already happening. There have been assembler memcpy/memset development test harnesses around that most arch developers are using, and those test things rather extensively. Also, the memcpy/memset routines on sparc in particular are completely shared with glibc, we use the same exact code in both trees. So it's getting tested there too. memmove() is just not handled this way.