From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752060AbbCWBNR (ORCPT ); Sun, 22 Mar 2015 21:13:17 -0400 Received: from mail-qg0-f43.google.com ([209.85.192.43]:33948 "EHLO mail-qg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751996AbbCWBNQ (ORCPT ); Sun, 22 Mar 2015 21:13:16 -0400 Date: Sun, 22 Mar 2015 21:13:13 -0400 From: Taesoo Kim To: Jaegeuk Kim Cc: Taesoo Kim , cm224.lee@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu, csong84@gatech.edu Subject: Re: [PATCH 1/1] f2fs: correctly check empty xattr key Message-ID: <20150323011313.GJ5170@taesoo.org> References: <1426825147-26981-1-git-send-email-tsgatesv@gmail.com> <20150320205201.GC19413@jaegeuk-mac02.mot.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150320205201.GC19413@jaegeuk-mac02.mot.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, Thank you for letting us know. We have another question: @f2fs_sync_file() if (unlikely(f2fs_readonly(inode->i_sb))) return 0; Isn't it better to report '-EROFS' as ext3/4? I suspect that f2fs returns 0 as fsync() man page doesn't specify such error condition. We are wondering if it is the real reason for f2fs's design decision. Thank you, Taesoo On 03/20/15 at 01:52pm, Jaegeuk Kim wrote: > Hi Taesoo, > > On Fri, Mar 20, 2015 at 12:19:07AM -0400, Taesoo Kim wrote: > > When xattr name (key) is empty (""), correctly return -EINVAL > > error. xattr_advise_set/get() seem to make the same mistake. > > The intention here is to disallow any xattr name, since this is used to get or > set the i_advise value by users. > > Thanks, > > > > > Signed-off-by: Taesoo Kim > > --- > > fs/f2fs/xattr.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c > > index 5072bf9..6b1fbc4 100644 > > --- a/fs/f2fs/xattr.c > > +++ b/fs/f2fs/xattr.c > > @@ -132,7 +132,7 @@ static int f2fs_xattr_advise_get(struct dentry *dentry, const char *name, > > { > > struct inode *inode = dentry->d_inode; > > > > - if (strcmp(name, "") != 0) > > + if (strcmp(name, "") == 0) > > return -EINVAL; > > > > *((char *)buffer) = F2FS_I(inode)->i_advise; > > @@ -144,7 +144,7 @@ static int f2fs_xattr_advise_set(struct dentry *dentry, const char *name, > > { > > struct inode *inode = dentry->d_inode; > > > > - if (strcmp(name, "") != 0) > > + if (strcmp(name, "") == 0) > > return -EINVAL; > > if (!inode_owner_or_capable(inode)) > > return -EPERM; > > -- > > 2.3.3