From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366AbbCWIkG (ORCPT ); Mon, 23 Mar 2015 04:40:06 -0400 Received: from mail.skyhub.de ([78.46.96.112]:46109 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbbCWIkD (ORCPT ); Mon, 23 Mar 2015 04:40:03 -0400 Date: Mon, 23 Mar 2015 09:38:21 +0100 From: Borislav Petkov To: Jim Kukunas Cc: Linux Kernel , tom.zanussi@linux.intel.com, Arjan van de Ven , "H. Peter Anvin" , tglx@linutronix.de, mingo@redhat.com, x86@kernel.org Subject: Re: [PATCH 10/11] x86/xip: resolve alternative instructions at build Message-ID: <20150323083821.GB31992@pd.tnic> References: <1427096800-30452-1-git-send-email-james.t.kukunas@linux.intel.com> <1427096800-30452-11-git-send-email-james.t.kukunas@linux.intel.com> <20150323083301.GA31992@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150323083301.GA31992@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2015 at 09:33:02AM +0100, Borislav Petkov wrote: > is this it? To save some memory? Probably embedded, maybe some light > bulb running linux... Yuck. Oh, one more thing: AFAICT, you're adding the whole XIP functionality with a bunch of ifdeffery in the main code paths. It might be better to extract and put all that code in arch/x86/xip/, away from the generic paths. I'm thinking there will be more XIP code coming besides this patchset so designing it clean from the get-go should pay out handsomely later. Hmm. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --