From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752353AbbCWOSY (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Mar 2015 10:18:24 -0400
Received: from smtprelay0035.hostedemail.com ([216.40.44.35]:39301 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752106AbbCWOSW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Mar 2015 10:18:22 -0400
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3622:3865:3866:3867:3871:3872:3874:5007:6119:6261:6742:7875:7903:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12114:12438:12517:12519:12740:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: fog20_2b31470fa4826
X-Filterd-Recvd-Size: 1705
Date: Mon, 23 Mar 2015 10:18:15 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: stop using PER_CPU_VAR(kernel_stack)
Message-ID: <20150323101815.35bd61c7@gandalf.local.home>
In-Reply-To: <1426970678-600-1-git-send-email-dvlasenk@redhat.com>
References: <1426970678-600-1-git-send-email-dvlasenk@redhat.com>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 21 Mar 2015 21:44:37 +0100
Denys Vlasenko <dvlasenk@redhat.com> wrote:

> Instead of PER_CPU_VAR(kernel_stack), 64-bit code
> can use PER_CPU_VAR(cpu_tss + TSS_sp0).

The change log here is lacking an answer to "why". It only states what
it does. What's wrong with using kernel_stack? The change log should
explicitly state that. I have no idea why this patch is needed.

-- Steve

> 
> 32-bit code switches to PER_CPU_VAR(cpu_current_top_of_stack),
> which has the same value.
>