From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932081AbbCWQBp (ORCPT ); Mon, 23 Mar 2015 12:01:45 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:35187 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752393AbbCWQBj (ORCPT ); Mon, 23 Mar 2015 12:01:39 -0400 Date: Mon, 23 Mar 2015 09:01:33 -0700 From: Dmitry Torokhov To: Bo Shen Cc: Jonathan Richardson , Dmitry Torokhov , Anatol Pomazau , Scott Branden , Grant Likely , Rob Herring , Ray Jui , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, bcm-kernel-feedback-list , devicetree@vger.kernel.org, Joe Perches , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala Subject: Re: [PATCH v5 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver Message-ID: <20150323160133.GB8666@dtor-ws> References: <1426899446-16873-1-git-send-email-jonathar@broadcom.com> <1426899446-16873-2-git-send-email-jonathar@broadcom.com> <550FE779.8010703@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <550FE779.8010703@atmel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bo, On Mon, Mar 23, 2015 at 06:14:17PM +0800, Bo Shen wrote: > Hi Jonathan Richardson, > > On 03/21/2015 08:57 AM, Jonathan Richardson wrote: > >+static struct platform_driver iproc_ts_driver = { > >+ .probe = iproc_ts_probe, > > Just a little curious, is the .remove function missing or it doesn't > need it. When all resources used by a driver are managed (i.e. acquired via devm API) such driver does not need remove() method. Thanks. -- Dmitry