From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753490AbbCWVzY (ORCPT ); Mon, 23 Mar 2015 17:55:24 -0400 Received: from ringil.hengli.com.au ([178.18.16.133]:55543 "EHLO ringil.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752221AbbCWVzU (ORCPT ); Mon, 23 Mar 2015 17:55:20 -0400 Date: Tue, 24 Mar 2015 08:55:13 +1100 From: Herbert Xu To: Sasha Levin Cc: "David S. Miller" , "netdev@vger.kernel.org" , LKML , Thomas Graf Subject: Re: rhashtable: warnings caused by "rhashtable: Fix use-after-free in rhashtable_walk_stop" Message-ID: <20150323215513.GA20128@gondor.apana.org.au> References: <55105B2E.1070409@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55105B2E.1070409@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2015 at 02:27:58PM -0400, Sasha Levin wrote: > Hi all, > > Commit 963ecbd41a ("rhashtable: Fix use-after-free in rhashtable_walk_stop") is causing > RCU warnings since the code now locks a mutex (which might sleep) within an RCU critical > section within rhashtable_walk_stop(). OK I will add a spin lock to bucket_table for this. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt