From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752314AbbCXHY5 (ORCPT ); Tue, 24 Mar 2015 03:24:57 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:55272 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbbCXHY4 (ORCPT ); Tue, 24 Mar 2015 03:24:56 -0400 Date: Tue, 24 Mar 2015 08:21:34 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Stefan Agner Cc: rjui@broadcom.com, sbranden@broadcom.com, f.fainelli@gmail.com, linux@arm.linux.org.uk, bcm@fixthebug.org, llvmlinux@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, mporter@linaro.org, jonathar@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: cygnus: fix const declaration bcm_cygnus_dt_compat Message-ID: <20150324072134.GO5664@pengutronix.de> References: <1426981535-1800-1-git-send-email-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1426981535-1800-1-git-send-email-stefan@agner.ch> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Stefan, On Sun, Mar 22, 2015 at 12:45:35AM +0100, Stefan Agner wrote: > The const declaration for char* is actually duplicated, however > the array of strings is currently not constant. However, typically > the dt_compat array is declared as const char *const. Follow > that convention and also add the __initconst macro for constant > initialization data. > > Signed-off-by: Stefan Agner Acked-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |