mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.cz>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Ingo Molnar <mingo@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	"David S. Miller" <davem@davemloft.net>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	Ananth NMavinakayanahalli <ananth@in.ibm.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] kprobes: Disable Kprobe when ftrace arming fails
Date: Tue, 24 Mar 2015 08:59:25 +0100	[thread overview]
Message-ID: <20150324075925.GH4500@dhcp128.suse.cz> (raw)
In-Reply-To: <alpine.LNX.2.00.1503232330320.6781@pobox.suse.cz>

On Mon 2015-03-23 23:36:00, Jiri Kosina wrote:
> On Mon, 23 Mar 2015, Ingo Molnar wrote:
> 
> > > > > wth is a 'universe' in this context?
> > > > 
> > > > We use the term "universe" to define whether the system or task uses
> > > > original or patched functions. It is especially important for patches
> > > > that modify semantic of functions. They need more complex consistency
> > > > model. It defines when it is safe time for the system or task to start
> > > > using the new functions (switch to the new universe).
> > > > 
> > > > In theory, different tasks might be in more universes if more patches are
> > > > being applied. In practice, we deal with only two universes. The trick is
> > > > that we allow to add new patch only when the whole system has switched
> > > > to the previous one.
> > > > 
> > > 
> > > Is this terminology documented anywhere upstream yet?
> > 
> > Even if it was documented (it isn't), 
> 
> There is no point in documenting it upstream, as no upstream code is using 
> this "universe" notation. It should just be removed from original Petr's 
> changelog and that's it.

Note that the term "universe" is not used in the commit message => no
change is needed.

I used the term to answer the question about interference between
Jprobes, ftrace, and live patches. I am sorry again. I should have
described it in a broader context.


Anyway, please, let me to repeat. This patch makes sense even without
live patching. The ftrace operations were there even before and might
have failed.

Best Regards,
Petr

  reply	other threads:[~2015-03-24  7:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 14:02 Petr Mladek
2015-03-23  8:54 ` Ingo Molnar
2015-03-23 10:12   ` Petr Mladek
2015-03-23 10:33     ` Ingo Molnar
2015-03-23 12:39       ` Petr Mladek
2015-03-23 13:30         ` Steven Rostedt
2015-03-23 13:34           ` Ingo Molnar
2015-03-23 13:43             ` Steven Rostedt
2015-03-23 13:53               ` Ingo Molnar
2015-03-23 13:58                 ` Steven Rostedt
2015-03-23 16:38                   ` Petr Mladek
2015-03-23 16:43               ` Paul E. McKenney
2015-03-23 23:32                 ` Jiri Kosina
2015-03-23 22:36             ` Jiri Kosina
2015-03-24  7:59               ` Petr Mladek [this message]
2015-03-24 13:36                 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150324075925.GH4500@dhcp128.suse.cz \
    --to=pmladek@suse.cz \
    --cc=ananth@in.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®