From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752712AbbCXLJD (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Mar 2015 07:09:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60049 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752417AbbCXLHr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Mar 2015 07:07:47 -0400
Date: Tue, 24 Mar 2015 12:07:19 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Namhyung Kim <namhyung@gmail.com>, Paul Mackerras <paulus@samba.org>,
        Stephane Eranian <eranian@google.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH V6 05/25] perf record: Add basic AUX area tracing support
Message-ID: <20150324110718.GB27134@krava.brq.redhat.com>
References: <1426509707-24961-1-git-send-email-adrian.hunter@intel.com>
 <1426509707-24961-6-git-send-email-adrian.hunter@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426509707-24961-6-git-send-email-adrian.hunter@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 16, 2015 at 02:41:27PM +0200, Adrian Hunter wrote:
> Amend the perf record tool to read the
> AUX area tracing mmap and synthesize
> AUX area tracing events.
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>  tools/perf/builtin-record.c | 80 ++++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 76 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 5a2ff51..8b3a50e 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -27,6 +27,7 @@
>  #include "util/cpumap.h"
>  #include "util/thread_map.h"
>  #include "util/data.h"
> +#include "util/auxtrace.h"
>  
>  #include <unistd.h>
>  #include <sched.h>
> @@ -38,6 +39,7 @@ struct record {
>  	struct record_opts	opts;
>  	u64			bytes_written;
>  	struct perf_data_file	file;
> +	struct auxtrace_record	*itr;
>  	struct perf_evlist	*evlist;
>  	struct perf_session	*session;
>  	const char		*progname;
> @@ -110,6 +112,43 @@ out:
>  	return rc;
>  }
>  
> +static int record__process_auxtrace(struct perf_tool *tool,
> +				    union perf_event *event, void *data1,
> +				    size_t len1, void *data2, size_t len2)
> +{
> +	struct record *rec = container_of(tool, struct record, tool);
> +	size_t padding;
> +	u8 pad[8] = {0};
> +
> +	/* event.auxtrace.size includes padding, see __auxtrace_mmap__read() */
> +	padding = (len1 + len2) & 7;
> +	if (padding)
> +		padding = 8 - padding;
> +
> +	record__write(rec, event, event->header.size);
> +	record__write(rec, data1, len1);
> +	record__write(rec, data2, len2);

record__write goes quite deep down the stack before it realizes
there's nothing to write (len2 == 0) which I'm guessing is the
likely case for data2/len2 (buffer wrap around) ?

maybe you want to check on that before calling that

jirka