From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752597AbbCXLIC (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Mar 2015 07:08:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57355 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752270AbbCXLH4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Mar 2015 07:07:56 -0400
Date: Tue, 24 Mar 2015 12:07:27 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Namhyung Kim <namhyung@gmail.com>, Paul Mackerras <paulus@samba.org>,
        Stephane Eranian <eranian@google.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH V6 04/25] perf tools: Add support for AUX area recording
Message-ID: <20150324110727.GC27134@krava.brq.redhat.com>
References: <1426509707-24961-1-git-send-email-adrian.hunter@intel.com>
 <1426509707-24961-5-git-send-email-adrian.hunter@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426509707-24961-5-git-send-email-adrian.hunter@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 16, 2015 at 02:41:26PM +0200, Adrian Hunter wrote:

SNIP

> +
> +int perf_event__synthesize_auxtrace(struct perf_tool *tool,
> +				    perf_event__handler_t process,
> +				    size_t size, u64 offset, u64 ref, int idx,
> +				    u32 tid, u32 cpu)
> +{
> +	union perf_event ev;
> +
> +	memset(&ev, 0, sizeof(ev));
> +	ev.auxtrace.header.type = PERF_RECORD_AUXTRACE;
> +	ev.auxtrace.header.size = sizeof(ev.auxtrace);
> +	ev.auxtrace.size = size;
> +	ev.auxtrace.offset = offset;
> +	ev.auxtrace.reference = ref;
> +	ev.auxtrace.idx = idx;
> +	ev.auxtrace.tid = tid;
> +	ev.auxtrace.cpu = cpu;
> +
> +	return process(tool, &ev, NULL, NULL);
> +}

I dont see this one being used/called from any place in your branch,
was it meant to be called from auxtrace_mmap__read?

jirka