From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752549AbbCXLHx (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Mar 2015 07:07:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52941 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752270AbbCXLHu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Mar 2015 07:07:50 -0400
Date: Tue, 24 Mar 2015 12:07:46 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Namhyung Kim <namhyung@gmail.com>, Paul Mackerras <paulus@samba.org>,
        Stephane Eranian <eranian@google.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH V6 02/25] perf evlist: Add initial support for mmapping
 an AUX area buffer
Message-ID: <20150324110746.GE27134@krava.brq.redhat.com>
References: <1426509707-24961-1-git-send-email-adrian.hunter@intel.com>
 <1426509707-24961-3-git-send-email-adrian.hunter@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426509707-24961-3-git-send-email-adrian.hunter@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 16, 2015 at 02:41:24PM +0200, Adrian Hunter wrote:

SNIP

> index 8d0b623..3cc7815 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -725,6 +725,34 @@ void perf_evlist__mmap_consume(struct perf_evlist *evlist, int idx)
>  		perf_evlist__mmap_put(evlist, idx);
>  }
>  
> +int __weak auxtrace_mmap__mmap(struct auxtrace_mmap *mm __maybe_unused,
> +			       struct auxtrace_mmap_params *mp __maybe_unused,
> +			       void *userpg __maybe_unused,
> +			       int fd __maybe_unused)
> +{
> +	return 0;
> +}
> +
> +void __weak auxtrace_mmap__munmap(struct auxtrace_mmap *mm __maybe_unused)
> +{
> +}
> +
> +void __weak auxtrace_mmap_params__init(
> +			struct auxtrace_mmap_params *mp __maybe_unused,
> +			off_t auxtrace_offset __maybe_unused,
> +			unsigned int auxtrace_pages __maybe_unused,
> +			bool auxtrace_overwrite __maybe_unused)
> +{
> +}
> +
> +void __weak auxtrace_mmap_params__set_idx(
> +			struct auxtrace_mmap_params *mp __maybe_unused,
> +			struct perf_evlist *evlist __maybe_unused,
> +			int idx __maybe_unused,
> +			bool per_cpu __maybe_unused)
> +{
> +}

IMO it's better to place the weak auxtrace_* functions in auxtrace header

jirka