From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753366AbbCXPnk (ORCPT ); Tue, 24 Mar 2015 11:43:40 -0400 Received: from smtprelay0086.hostedemail.com ([216.40.44.86]:50678 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752806AbbCXPng (ORCPT ); Tue, 24 Mar 2015 11:43:36 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:69:355:379:541:599:800:960:965:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3874:4250:4390:4605:5007:6261:6299:7875:10004:10400:10848:10967:11232:11658:11914:12517:12519:12740:13069:13311:13357:14096:14097:21067:21080:21094,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: north70_769c6a6c99155 X-Filterd-Recvd-Size: 1841 Date: Tue, 24 Mar 2015 11:43:34 -0400 From: Steven Rostedt To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Jiri Olsa , Namhyung Kim , Andrew Morton Subject: Re: [PATCH 2/9] tools lib traceevent: Copy trace_clock and free it Message-ID: <20150324114334.5b43c362@gandalf.local.home> In-Reply-To: <20150324151449.GC5447@kernel.org> References: <20150324135748.506437888@goodmis.org> <20150324135922.695906738@goodmis.org> <20150324151449.GC5447@kernel.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Mar 2015 12:14:49 -0300 Arnaldo Carvalho de Melo wrote: > Humm, strdup actually sets errno already, from its man page: > > ------------------- > > RETURN VALUE > On success, the strdup() function returns a pointer to the > duplicated string. It returns NULL if insufficient memory was > available, with errno set to indicate the cause of the error. > > ------------------- > > > Applying anyway, as this doesn't introduces a problem, right? > Ah, I didn't realize that. I probably should of. The original code just had a "die()" in it. But I know how much Namhyung loves those ;-) I removed the die() and noticed that the other removed "die()"s also set errno = ENOMEM. Those probably could also be removed as they happen after "remalloc" and such. -- Steve