From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbbCXNHl (ORCPT ); Tue, 24 Mar 2015 09:07:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60887 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130AbbCXNHj (ORCPT ); Tue, 24 Mar 2015 09:07:39 -0400 Date: Tue, 24 Mar 2015 14:06:50 +0100 From: Jiri Olsa To: Adrian Hunter Cc: Alexander Shishkin , Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, Robert Richter , Frederic Weisbecker , Mike Galbraith , Paul Mackerras , Stephane Eranian , Andi Kleen , kan.liang@intel.com, markus.t.metzger@intel.com, mathieu.poirier@linaro.org, Kaixu Xia , acme@infradead.org Subject: Re: [PATCH v9 06/14] perf: Add AUX record Message-ID: <20150324130650.GB5337@krava.brq.redhat.com> References: <1421237903-181015-1-git-send-email-alexander.shishkin@linux.intel.com> <1421237903-181015-7-git-send-email-alexander.shishkin@linux.intel.com> <20150324110736.GD27134@krava.brq.redhat.com> <55114A1A.6060301@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55114A1A.6060301@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 01:27:22PM +0200, Adrian Hunter wrote: > On 24/03/15 13:07, Jiri Olsa wrote: > > On Wed, Jan 14, 2015 at 02:18:15PM +0200, Alexander Shishkin wrote: > >> When there's new data in the AUX space, output a record indicating its > >> offset and size and a set of flags, such as PERF_AUX_FLAG_TRUNCATED, to > >> mean the described data was truncated to fit in the ring buffer. > >> > >> Signed-off-by: Alexander Shishkin > >> Cc: Arnaldo Carvalho de Melo > >> --- > >> include/uapi/linux/perf_event.h | 19 +++++++++++++++++++ > >> kernel/events/core.c | 34 ++++++++++++++++++++++++++++++++++ > >> kernel/events/internal.h | 3 +++ > >> 3 files changed, 56 insertions(+) > >> > >> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > >> index b7ccdf5e93..2d40e2aa07 100644 > >> --- a/include/uapi/linux/perf_event.h > >> +++ b/include/uapi/linux/perf_event.h > >> @@ -746,6 +746,20 @@ enum perf_event_type { > >> */ > >> PERF_RECORD_MMAP2 = 10, > >> > >> + /* > >> + * Records that new data landed in the AUX buffer part. > >> + * > >> + * struct { > >> + * struct perf_event_header header; > >> + * > >> + * u64 aux_offset; > >> + * u64 aux_size; > >> + * u64 flags; > >> + * struct sample_id sample_id; > > > > hum, I dont see sample_id below in implementation > > Alex is away, so I will take the liberty of answering. > > perf_event_aux_event() calls perf_event__output_id_sample() > That's it isn't it? argh, now I see it ;-) sry jirka