From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932128AbbCXPta (ORCPT ); Tue, 24 Mar 2015 11:49:30 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:42893 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752802AbbCXPtY (ORCPT ); Tue, 24 Mar 2015 11:49:24 -0400 Date: Tue, 24 Mar 2015 16:48:55 +0100 From: Peter Zijlstra To: John Stultz Cc: Thomas Gleixner , =?utf-8?B?UGF3ZcWC?= Moll , Adrian Hunter , Ingo Molnar , Stephane Eranian , lkml , Arnaldo Carvalho de Melo , David Ahern , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Jiri Olsa , Namhyung Kim , Paul Mackerras , Steven Rostedt , Sonny Rao , "ak@linux.intel.com" , vincent.weaver@maine.edu Subject: Re: [RFC][PATCH 0/4] Another go at ktime_get_raw_fast_ns() Message-ID: <20150324154855.GQ21418@twins.programming.kicks-ass.net> References: <20150319093137.149794496@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 08:20:07AM -0700, John Stultz wrote: > On Thu, Mar 19, 2015 at 2:31 AM, Peter Zijlstra wrote: > > Hi John, > > > > So yeah, I just didn't try hard enough it seems; how about this? > > Yea, this looks much better! I'll queue it up for testing and if that > goes well include it for 4.1. I have a few patches that depend on it, so if you're ok with it I'd like to carry the lot. But yes please test ;-) > > Also, I think we should double check that everything passed to > > tk_setup_internals(.clock) is either static storage or RCU-sched freed, > > because with the whole latch thing one CPUs (fast) access might still be > > in progress while the other is freeing the clock struct. > > > > Not sure what the lifetime rules of struct clocksource are here. > > At one point it was install and never remove, but I think Thomas > changed that awhile back, so I think your concern here is a good one. OK, I'll try and dig around a bit on this.